Skip to content

fix: filter system fields from vanilla FAISS params#1649

Merged
foxspy merged 1 commit into
zilliztech:mainfrom
foxspy:faiss-passthrough
May 28, 2026
Merged

fix: filter system fields from vanilla FAISS params#1649
foxspy merged 1 commit into
zilliztech:mainfrom
foxspy:faiss-passthrough

Conversation

@foxspy
Copy link
Copy Markdown
Collaborator

@foxspy foxspy commented May 27, 2026

issue: #1648

Summary

  • Filter framework metadata out of vanilla FAISS raw parameter forwarding
  • Keep valid FAISS parameters such as nprobe and efSearch in raw_params
  • Add unit coverage for filtering system fields while preserving FAISS params

Tests

  • pre-commit run --files src/index/faiss/faiss_config.h tests/ut/test_faiss_vanilla.cc
  • LD_LIBRARY_PATH=/home/fox/.conan/data/gflags/2.2.2///package/2a6a3278a322171d7bc88cf0269269647987854f/lib:$LD_LIBRARY_PATH ./build/tests/ut/knowhere_tests "FaissConfig parses faiss_index_name and captures raw JSON"
  • LD_LIBRARY_PATH=/home/fox/.conan/data/gflags/2.2.2///package/2a6a3278a322171d7bc88cf0269269647987854f/lib:$LD_LIBRARY_PATH ./build/tests/ut/knowhere_tests "FAISS: typo key surfaces faiss error at build"

@mergify mergify Bot added the dco-passed label May 27, 2026
@foxspy foxspy added the kind/bug This PR is a bug fix label May 27, 2026
Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, marcelo-cjl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marcelo-cjl
Copy link
Copy Markdown
Collaborator

/lgtm

@foxspy foxspy merged commit b1540ae into zilliztech:main May 28, 2026
12 of 16 checks passed
@mergify mergify Bot removed the ci-passed label May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants