perf: optimized the checkCreatureAsKnown function #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creature removal is now much faster as we avoid unnecessarily iterating over large sets. The code is more organized and easier to understand, with clear helper functions. The solution is scalable and can easily handle larger limits of known creatures if needed. The optimized code above significantly improves the performance and maintainability of the known creatures cache system in OTServ. It resolves issues related to unnecessary iteration and inefficient data structures, ensuring faster and more reliable operation.
|
Contributor
|
This PR is stale because it has been open 45 days with no activity. |
|
W4gNII
approved these changes
Apr 16, 2025
| ++it; | ||
| // We need to protect party players from removing | ||
| const auto &checkPlayer = creature->getPlayer(); | ||
| if (!checkPlayer || (checkPlayer->getParty() != player->getParty() && !canSee(creature))) { |
There was a problem hiding this comment.
aqui é necessário fazer uma checagem a mais
if ((checkPlayer && (checkPlayer->getParty() != player->getParty() && !canSee(creature))) || (!checkPlayer && !canSee(creature))) {
jprzimba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creature removal is now much faster as we avoid unnecessarily iterating over large sets.
The code is more organized and easier to understand, with clear helper functions.
The solution is scalable and can easily handle larger limits of known creatures if needed. The optimized code above significantly improves the performance and maintainability of the known creatures cache system in OTServ.
It resolves issues related to unnecessary iteration and inefficient data structures, ensuring faster and more reliable operation.