Skip to content

fix: Refactor chain combat to separate initial and chain damage#802

Merged
jprzimba merged 1 commit into
mainfrom
fix-chain
Jun 29, 2026
Merged

fix: Refactor chain combat to separate initial and chain damage#802
jprzimba merged 1 commit into
mainfrom
fix-chain

Conversation

@jprzimba

Copy link
Copy Markdown
Collaborator

Modify weapon combat to always apply damage to the initial target first, then apply chain effects to subsequent targets. This is achieved by:

  • Adding a disableFirstTarget parameter to doCombatChain to skip the first chain target
  • Restructuring weapon attack flow to always call doCombatHealth for the initial target
  • Updating chain effect execution to use getCombatDamage and CombatHealthFunc directly for consistency

This ensures the primary target is always hit first before chain effects are applied to other targets.

@jprzimba jprzimba merged commit c7fce32 into main Jun 29, 2026
22 checks passed
@jprzimba jprzimba deleted the fix-chain branch June 29, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant