fix: arrays.colors dropdown and startup race condition#863
Conversation
- Add built-in array references (arrays.colors, arrays.positions, arrays.radii) to dynamic enum dropdowns in geometry forms - Fix race condition when running `zndraw file.h5` by adding ?template=none to browser URL, ensuring room starts with 0 frames until Celery uploads file data Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThis PR modifies JSON form enum injection to handle dynamic atom properties without requiring metadata presence by computing enum references from built-in arrays, and adjusts CLI room URL construction to append a template parameter when loading files to prevent race conditions. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #863 +/- ##
==========================================
+ Coverage 80.01% 80.02% +0.01%
==========================================
Files 165 165
Lines 20131 20133 +2
==========================================
+ Hits 16108 16112 +4
+ Misses 4023 4021 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zndraw file.h5by adding ?template=none to browser URL, ensuring room starts with 0 frames until Celery uploads file dataSummary by CodeRabbit
Bug Fixes
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.