fix: taskiq worker healthcheck and cross-replica socket events#879
fix: taskiq worker healthcheck and cross-replica socket events#879
Conversation
The taskiq-worker container inherited the Dockerfile HEALTHCHECK which pings :8000 — but the worker has no HTTP server, so it was permanently "unhealthy". Override with a pgrep-based process check in both compose files. Bump zndraw-socketio>=0.1.6 which fixes AsyncRedisManager not being set on the underlying socketio.AsyncServer (was stored on the wrapper only), causing socket events to never cross replicas via Redis pub/sub. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughDocker Compose configurations for both production and standalone environments now include health monitoring for the taskiq-worker service. Additionally, the minimum required version constraint for the zndraw-socketio dependency was incremented. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
+ Coverage 91.12% 91.23% +0.10%
==========================================
Files 179 179
Lines 17270 17270
==========================================
+ Hits 15738 15756 +18
+ Misses 1532 1514 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
:8000) but has no web server — always reported "unhealthy". Overridden withpgrep -f 'taskiq worker'in both standalone and production compose files.zndraw-socketio>=0.1.6which fixesAsyncRedisManagerbeing stored on the wrapper instead of the underlyingsocketio.AsyncServer. This caused socket events to only reach clients on the same replica, breaking real-time updates from taskiq workers in multi-replica deployments.Test plan
docker compose psshows taskiq-worker as "healthy"🤖 Generated with Claude Code
Summary by CodeRabbit