Skip to content

moved perf_test, removed perf, modified perfTest yml files#1217

Merged
sonalgoyal merged 1 commit intozinggAI:mainfrom
padam-prakash:Issue##1216-move-perf_test
Nov 11, 2025
Merged

moved perf_test, removed perf, modified perfTest yml files#1217
sonalgoyal merged 1 commit intozinggAI:mainfrom
padam-prakash:Issue##1216-move-perf_test

Conversation

@padam-prakash
Copy link
Copy Markdown
Contributor

moved perf_test, removed perf, modified perfTest yml files. Fixes #1216

moved perf_test, removed perf, modified perfTest yml files
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves performance test data out of the main repository and modifies GitHub Actions workflows to use the relocated data from a separate performance reports repository. The key changes include:

  • Deletion of local performance test data files (120k.out and zdupes outputs)
  • Updates to CI/CD workflows to clone the external zingg_community_performance_reports repository
  • Corrections to path references in workflow files

Reviewed Changes

Copilot reviewed 14 out of 705 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
perf/120k6MinWholeGraph/zdupes/part-00010 Removed large test data file (1592 lines)
perf/120k6MinWholeGraph/zdupes/part-00009 Removed large test data file (2209 lines)
perf/120k.out Removed performance test output file
.github/workflows/perfTest-ncVoters5M.yml Updated to clone external repo and adjusted input path
.github/workflows/perfTest-febrl120K.yml Updated to clone external repo and adjusted input path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- name: Build with Maven
run: mvn clean compile package -DskipTests=true
- name: Clone performance reports repo
run: git clone https://github.com/zinggAI/zingg_community_performance_reports.git
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git clone command lacks authentication and error handling. If the repository becomes private or is temporarily unavailable, the workflow will fail. Consider adding error handling and potentially using a GitHub token for authentication to ensure reliability.

Suggested change
run: git clone https://github.com/zinggAI/zingg_community_performance_reports.git
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
git clone https://x-access-token:${GITHUB_TOKEN}@github.com/zinggAI/zingg_community_performance_reports.git || { echo "Failed to clone repository"; exit 1; }

Copilot uses AI. Check for mistakes.
- name: Build with Maven
run: mvn clean compile package -DskipTests=true
- name: Clone performance reports repo
run: git clone https://github.com/zinggAI/zingg_community_performance_reports.git
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git clone command lacks authentication and error handling. If the repository becomes private or is temporarily unavailable, the workflow will fail. Consider adding error handling and potentially using a GitHub token for authentication to ensure reliability.

Suggested change
run: git clone https://github.com/zinggAI/zingg_community_performance_reports.git
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
set -e
git clone https://x-access-token:${GITHUB_TOKEN}@github.com/zinggAI/zingg_community_performance_reports.git || { echo "Failed to clone repository"; exit 1; }

Copilot uses AI. Check for mistakes.
@sonalgoyal sonalgoyal merged commit 890c844 into zinggAI:main Nov 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move perf directory to zinggAI/zingg_community_performance_reports

3 participants