Merged
Conversation
This structure was largely my own construction, so I thought it would be reasonable to factor it into a more coherent flow. The struct that is set up as a function of the command line arguments (as parsed by clap) is now called a ConfigTemplate. Its constructor is now named "fill". The 'filled' config template is now passed between the operational functions of the library. This decomposes configuration from other tasks (like launch). I hope this is more understandable.
The codebase had stubs for future functionality. Apparently there was an intention to support in-wallet encryption and locking. Since these features don't yet exist, and might be better handled as a separate concern, we're removing this stub-code.
AloeareV
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.