Merged
Conversation
Member
Author
|
zingolib/zingolib/src/commands.rs Line 373 in ae6fe11 The underlying implementation now counts all shielded outputs to calculate the total (instead of just counting Sapling outputs). |
fluidvanadium
previously approved these changes
Sep 22, 2023
Contributor
fluidvanadium
left a comment
fluidvanadium
left a comment
There was a problem hiding this comment.
this looks good, but juanky should get a chance to look at it
zancas
dismissed
fluidvanadium’s stale review
The merge-base changed after approval.
Contributor
Thanks @fluidvanadium ... I saw it and I believe the update of |
Member
Author
|
OK, can someone please Approve this? |
zancas
dismissed
juanky201271’s stale review
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @juanky201271 the last commit in this PR will change the definition of:
SendProgressCommandlink in following comment.