Switch to Bzip-rs and zlib-rs?

[philocalyst]

• https://github.com/trifectatechfoundation/zlib-rs
• https://github.com/trifectatechfoundation/libbzip2-rs

[Its-Just-Nans]

Hi

https://github.com/trifectatechfoundation/zlib-rs

I think we already have the feature to enable it in the Cargo.toml

deflate-flate2-zlib-rs = ["deflate-flate2", "flate2/zlib-rs"]

https://github.com/trifectatechfoundation/libbzip2-rs

I think we are already using it by default

├── bzip2 v0.6.1
│    └── libbz2-rs-sys v0.2.2

Linked to trifectatechfoundation/libbzip2-rs#127

Feel free to correct me if I'm wrong

[folkertdev]

Yes, you're pinning bzip2 0.6, which will use libbzip2-rs-sys by default for zip2. However due to MSRV or other dependencies an earlier version might also show up in your project's dependency tree.

[Its-Just-Nans]

However due to MSRV or other dependencies an earlier version might also show up in your project's dependency tree.

I thought that cargo can only use bzip@0.6 OR bzip@0.5 OR bizp@0.4 etc.. And since we require bzip@0.6, we can only use the bzip@0.6 no?

Linked to

• 0f391db
• c827899

[folkertdev]

For zip2 itself that is true, but in a larger dependency tree it's possible for two different versions of e.g. bzip2 to be compiled. Historically that didn't work well because there would be duplicate extern symbols, but libbzip2-rs-sys does not export symbols so it's technically a possibility.

It's inefficient though, so the solver tries to prevent this normally.