feat: add must_use

[Its-Just-Nans]

Add must_use

needs a minor bump

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the codebase's robustness and clarity by introducing explicit checks for unused function return values. By enabling a new Clippy lint and applying the #[must_use] attribute to key functions, it helps prevent potential bugs arising from ignored results, thereby improving overall code reliability and maintainability.

Highlights

• Linting: Enabled the clippy::must_use_candidate lint to enforce the usage of function return values where appropriate.
• Code Quality: Applied the #[must_use] attribute to several functions, including System::from_version_made_by, FileOptions::into_full_options, and ZipWriter::set_auto_large_file, to ensure their return values are not accidentally ignored.

Changelog

• src/lib.rs
  • Added clippy::must_use_candidate to the crate-level lints.
• src/types.rs
  • Applied #[must_use] attribute to the System::from_version_made_by function.
• src/write.rs
  • Applied #[must_use] attribute to the FileOptions::into_full_options function.
  • Applied #[must_use] attribute to the ZipWriter::set_auto_large_file function.

Activity

• No human activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[amazon-q-developer]

This PR adds #[must_use] attributes to improve API ergonomics and enables the clippy::must_use_candidate lint. All changes are code quality improvements with no functional defects blocking merge.

---

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

[gemini-code-assist]

Code Review

This pull request introduces the clippy::must_use_candidate lint to the project, and subsequently applies the #[must_use] attribute to several functions and methods, including System::from_version_made_by, FileOptions::into_full_options, and ZipWriter::set_auto_large_file. This change ensures that the return values of these functions are explicitly handled, preventing potential bugs from ignored results.