refactor: move code to distinct file (datetime, FixedSizeBlock) by Its-Just-Nans · Pull Request #733 · zip-rs/zip2

Its-Just-Nans · 2026-03-18T19:01:15Z

move DateTime to a new datetime.rs
move FixedSizeBlock inside spec
remove function unsupported_zip_error

gemini-code-assist · 2026-03-18T19:01:34Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on refactoring the codebase to improve organization and maintainability. It involves moving the DateTime structure and its extensive implementations into its own file, and consolidating various fixed-size ZIP block definitions into the spec.rs file. These changes aim to create a clearer separation of concerns and make the codebase easier to navigate and understand.

Highlights

Code Organization: Moved the DateTime struct and its associated logic to a new dedicated file, src/datetime.rs, improving modularity.
ZIP Specification Structs: Relocated FixedSizeBlock implementations and related ZIP block structs (e.g., ZipCentralEntryBlock, ZipLocalEntryBlock) from src/types.rs to src/spec.rs, centralizing ZIP specification-related code.
Error Handling Refinement: Replaced the unsupported_zip_error helper function in src/read.rs with direct Err(ZipError::UnsupportedArchive(...)) returns, simplifying error handling.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

amazon-q-developer

This refactoring successfully reorganizes code by moving DateTime to src/datetime.rs and ZIP block structures to src/spec.rs. The changes relocate code without modifying functionality, and the removal of the unsupported_zip_error helper in favor of direct Err(ZipError::UnsupportedArchive(...)) calls is correctly implemented. No blocking defects found.

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

src/spec.rs

gemini-code-assist

Code Review

The pull request successfully refactors the DateTime struct and fixed-size block definitions into their own dedicated files, src/datetime.rs and src/spec.rs respectively. This improves modularity and organization within the codebase. The inlining of unsupported_zip_error in src/read.rs also simplifies error handling in those specific locations.

src/datetime.rs

src/spec.rs

src/types.rs

src/datetime.rs

src/spec.rs


+#[derive(Copy, Clone, Debug)]
+#[repr(packed, C)]
+pub(crate) struct ZipCentralEntryBlock {


src/spec.rs

+
+#[derive(Copy, Clone, Debug)]
+#[repr(packed, C)]
+pub(crate) struct ZipLocalEntryBlock {


src/spec.rs

+
+#[derive(Copy, Clone, Debug)]
+#[repr(packed, C)]
+pub(crate) struct ZipLocalEntryBlock {


src/spec.rs

+
+#[derive(Copy, Clone, Debug)]
+#[repr(packed, C)]
+pub(crate) struct ZipLocalEntryBlock {


src/spec.rs

+
+#[derive(Copy, Clone, Debug)]
+#[repr(packed, C)]
+pub(crate) struct ZipLocalEntryBlock {


src/spec.rs

+
+#[derive(Copy, Clone, Debug)]
+#[repr(packed, C)]
+pub(crate) struct ZipLocalEntryBlock {


src/spec.rs

+
+#[derive(Copy, Clone, Debug)]
+#[repr(packed, C)]
+pub(crate) struct ZipLocalEntryBlock {


Its-Just-Nans added 7 commits March 18, 2026 09:53

Update read.rs

ac727ab

Move to specs

10869c9

move to spec.rs

f74100b

Update types.rs

171bac0

Create datetime.rs

5533849

Update types.rs

87c775a

Update datetime.rs

99cc870

amazon-q-developer bot reviewed Mar 18, 2026

View reviewed changes

github-advanced-security bot found potential problems Mar 18, 2026

View reviewed changes

gemini-code-assist bot reviewed Mar 18, 2026

View reviewed changes

src/datetime.rs Show resolved Hide resolved

src/spec.rs Show resolved Hide resolved

Its-Just-Nans added 8 commits March 18, 2026 13:05

Update read.rs

093b1bc

Update types.rs

5bed490

Update spec.rs

620a5f2

Update spec.rs

7c2b93a

Update read.rs

e657185

Update types.rs

d01b529

Update types.rs

9181199

Update datetime.rs

069e5e6

github-advanced-security bot found potential problems Mar 18, 2026

View reviewed changes

src/types.rs Fixed Show fixed Hide fixed

Update lib.rs

897d9ef

github-advanced-security bot found potential problems Mar 18, 2026

View reviewed changes

Its-Just-Nans added 7 commits March 18, 2026 13:28

Update types.rs

2424622

Update datetime.rs

9c0f1a9

Update datetime.rs

c99429d

Update lib.rs

5ca7163

Update read.rs

084cfb2

Update stream.rs

efe7f8f

Update types.rs

96f87df

Its-Just-Nans added 2 commits March 18, 2026 14:07

Update write.rs

b48a8dd

Update spec.rs

7c62f70

github-advanced-security bot found potential problems Mar 18, 2026

View reviewed changes

Its-Just-Nans added 3 commits March 18, 2026 17:10

cargo fmt

7323f91

fix and merge

85dcb1c

cargo fmt

85446f0

Its-Just-Nans enabled auto-merge March 18, 2026 23:56

Its-Just-Nans added this pull request to the merge queue Mar 19, 2026

Its-Just-Nans self-assigned this Mar 19, 2026

Merged via the queue into master with commit 5fe3f1d Mar 19, 2026
130 checks passed

Its-Just-Nans deleted the Its-Just-Nans-patch-1 branch March 19, 2026 04:14

Pr0methean mentioned this pull request Mar 19, 2026

chore: release v8.3.0 #729

Merged

Conversation

Its-Just-Nans commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Mar 18, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

amazon-q-developer bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Its-Just-Nans commented Mar 18, 2026 •

edited

Loading