refactor: remove unused allow

[Its-Just-Nans]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the codebase by removing obsolete lint allowances that are no longer required due to updates in Rust's linting capabilities. Additionally, a minor documentation improvement was made to enhance clarity within a code comment. The overall impact is a cleaner, more maintainable codebase with fewer unnecessary suppressions.

Highlights

• Lint allowance removal: Removed the #[allow(unknown_lints)] attribute related to invalid_from_utf8 in src/cp437.rs as it is no longer necessary due to Rust version updates.
• Unused lint removal: Eliminated #[allow(unknown_lints)] and #[allow(non_local_definitions)] from src/result.rs, streamlining the codebase by removing obsolete lint suppressions.
• Documentation clarity: Improved a comment in src/read/stream.rs by using a more specific reference to ZipLocalEntryBlock::parse for better understanding.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[amazon-q-developer]

This PR successfully removes unnecessary lint suppressions and makes minor code improvements. The changes include:

• Removal of #[allow(unknown_lints)] and #[allow(non_local_definitions)] from src/result.rs
• Removal of outdated #[allow(unknown_lints)] comment from src/cp437.rs
• Simplification of ::std::str::from_utf8 to std::str::from_utf8
• Improved code documentation formatting with backticks

The PR title follows the Conventional Commits format with the refactor: prefix. All changes are non-functional improvements that clean up the codebase without affecting behavior.

---

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

[gemini-code-assist]

Code Review

This pull request consists of refactoring to remove unused allow attributes, likely due to an MSRV update. The changes in src/cp437.rs and src/result.rs are correct. Additionally, there's a minor style fix in src/cp437.rs and a documentation improvement in src/read/stream.rs. The changes are sound and I have no suggestions for improvement.