refactor: remove macro export#792
Conversation
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR correctly removes the public export of the to_and_from_le macro, making it properly scoped as an internal implementation detail. The version bump to 9.0.0 appropriately reflects this breaking change. The refactoring is clean with no defects identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the crate version to 9.0.0 and removes the #[macro_export] attribute from the to_and_from_le! macro in src/spec.rs. A review comment points out that the deprecated-time feature should be removed in this major version update to remain consistent with the crate's documented deprecation policy.
| [package] | ||
| name = "zip" | ||
| version = "8.6.0" | ||
| version = "9.0.0" |
There was a problem hiding this comment.
The version is being bumped to 9.0.0, but the deprecated-time feature (defined at line 92) is still present. The comment at line 91 explicitly states that this feature will be removed in version 9.0.0. To maintain consistency with the crate's deprecation policy and fulfill the promise made in the comments, this feature should be removed as part of this major version update.
2 participants
No description provided.