refactor!: Remove deprecated elements#802
Conversation
There was a problem hiding this comment.
This PR cleanly removes deprecated elements in preparation for version 9.0.0. The changes are well-structured and include:
- Removal of the
deprecated-timefeature flag and associated implementations - Removal of deprecated methods (
sanitized_name,zip64_comment) - Removal of deprecated enum variant
FromCentralDirectory - Minor refactoring improvements (method ordering, simplified function calls, import path cleanup)
The removals are appropriate for a major version release, and all changes maintain backward compatibility within the new major version. No defects or security issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Code Review
This pull request focuses on cleaning up the codebase by removing deprecated features and methods, specifically the deprecated-time feature, the sanitized_name and zip64_comment functions, and the FromCentralDirectory enum variant. Additionally, it includes minor refactoring of internal paths and trait implementations. Feedback suggests that the removal of the deprecated-time feature may have resulted in dead code within the test suite and that documentation for ArchiveOffset requires updates to reflect the removed variant.
Uh oh!
There was an error while loading. Please reload this page.