Skip to content

refactor!: Remove deprecated elements#802

Merged
Pr0methean merged 4 commits intomasterfrom
remove-deprecated-9.0.0
May 3, 2026
Merged

refactor!: Remove deprecated elements#802
Pr0methean merged 4 commits intomasterfrom
remove-deprecated-9.0.0

Conversation

@Pr0methean
Copy link
Copy Markdown
Member

@Pr0methean Pr0methean commented May 3, 2026

@Pr0methean Pr0methean added this to the 9.0.0 milestone May 3, 2026
Copy link
Copy Markdown
Contributor

@amazon-q-developer amazon-q-developer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR cleanly removes deprecated elements in preparation for version 9.0.0. The changes are well-structured and include:

  • Removal of the deprecated-time feature flag and associated implementations
  • Removal of deprecated methods (sanitized_name, zip64_comment)
  • Removal of deprecated enum variant FromCentralDirectory
  • Minor refactoring improvements (method ordering, simplified function calls, import path cleanup)

The removals are appropriate for a major version release, and all changes maintain backward compatibility within the new major version. No defects or security issues identified.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on cleaning up the codebase by removing deprecated features and methods, specifically the deprecated-time feature, the sanitized_name and zip64_comment functions, and the FromCentralDirectory enum variant. Additionally, it includes minor refactoring of internal paths and trait implementations. Feedback suggests that the removal of the deprecated-time feature may have resulted in dead code within the test suite and that documentation for ArchiveOffset requires updates to reflect the removed variant.

Comment thread Cargo.toml
Comment thread src/read/config.rs
@Pr0methean Pr0methean enabled auto-merge May 3, 2026 00:47
@Pr0methean Pr0methean mentioned this pull request May 3, 2026
2 tasks
@Pr0methean Pr0methean added this pull request to the merge queue May 3, 2026
Merged via the queue into master with commit 279ebdb May 3, 2026
133 checks passed
@Pr0methean Pr0methean deleted the remove-deprecated-9.0.0 branch May 3, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant