refactor: don't store converted filenames; convert on demand instead; and don't use Arc since it only deduplicates when copying to same path in another archive#807
Merged
Pr0methean merged 52 commits intomasterfrom May 4, 2026
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: n4n5 <git@n4n5.dev>
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This PR refactors the file name storage mechanism from Arc<str> to using raw bytes directly. However, there are critical compilation errors that prevent this code from building:
- Line 561 in src/read.rs: Undefined variable
file_name_arc- this variable is referenced but never declared - Line 568 in src/read.rs: Assignment to removed field
result.file_name- the field was removed fromZipFileDatabut this assignment remains - Line 218 in src/types.rs: Reference to non-existent
self.is_utf8property - should useZipFlags::matchinginstead
These errors will cause compilation failure and block merge. The refactoring approach of removing the file_name: Arc<str> field and using raw bytes is sound, but the implementation is incomplete with several references to the old structure remaining in the code.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Pr0methean
previously approved these changes
May 4, 2026
Pr0methean
changed the title
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.