refactor: update some extra field#821
Conversation
There was a problem hiding this comment.
The refactoring changes look good. The transition from Pod trait usage to explicit write() methods for extra field serialization improves code clarity and follows better practices. All call sites have been updated correctly to use the new APIs. No blocking issues found.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Code Review
This pull request refactors the serialization of AexEncryption and Zip64ExtendedInformation extra fields to write directly to a Write trait object, removing the dependency on the Pod trait and simplifying struct definitions. The review feedback identifies a critical missing import for size_of that would prevent compilation and suggests several performance optimizations, specifically using stack-allocated arrays and pre-allocating Vec capacity to avoid unnecessary heap allocations for fixed-size data.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: n4n5 <git@n4n5.dev>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: n4n5 <git@n4n5.dev>
Pr0methean
left a comment
There was a problem hiding this comment.
One nitpick, and the Gemini feedback looks helpful as well.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
|
Yes thanks But I'm drafting it wince I need to add a test for the update_ees function (never tested) |
|
I have fixed the nitpick The MR will merge when ready |
Start to change to extra field
The function
update_aes_extra_datais never tested (we can remove the call and all tests are fine)I will update this branch with a test