Skip to content

refactor: change zip64 parsing#834

Merged
Pr0methean merged 1 commit into
masterfrom
refactor-zip64
May 12, 2026
Merged

refactor: change zip64 parsing#834
Pr0methean merged 1 commit into
masterfrom
refactor-zip64

Conversation

@Its-Just-Nans
Copy link
Copy Markdown
Member

Part of extra field rewrite

@Its-Just-Nans Its-Just-Nans self-assigned this May 11, 2026
Copy link
Copy Markdown
Contributor

@amazon-q-developer amazon-q-developer Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring successfully converts the Zip64ExtendedInformation::parse method from using mutable references to returning values, improving code clarity and eliminating side effects. The changes are consistent across both files, and the logic remains functionally equivalent.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Zip64ExtendedInformation::parse function to return updated values as a tuple instead of modifying them via mutable references, with corresponding updates to its call site in src/read/mod.rs. Feedback suggests further improving the parse function by extracting repetitive field-reading logic into a closure to reduce boilerplate and improve maintainability.

Comment thread src/extra_fields/zip64_extended_information.rs
@Its-Just-Nans Its-Just-Nans enabled auto-merge May 11, 2026 20:13
@Its-Just-Nans Its-Just-Nans added this pull request to the merge queue May 11, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 11, 2026
@Pr0methean Pr0methean added this pull request to the merge queue May 12, 2026
Merged via the queue into master with commit 5f3730c May 12, 2026
134 checks passed
@Pr0methean Pr0methean deleted the refactor-zip64 branch May 12, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants