refactor: change zip64 parsing#834
Conversation
There was a problem hiding this comment.
The refactoring successfully converts the Zip64ExtendedInformation::parse method from using mutable references to returning values, improving code clarity and eliminating side effects. The changes are consistent across both files, and the logic remains functionally equivalent.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Code Review
This pull request refactors the Zip64ExtendedInformation::parse function to return updated values as a tuple instead of modifying them via mutable references, with corresponding updates to its call site in src/read/mod.rs. Feedback suggests further improving the parse function by extracting repetitive field-reading logic into a closure to reduce boilerplate and improve maintainability.
Part of extra field rewrite