Hand-Eye GUI: Surface capture errors to the user#226
Merged
Conversation
csu-bot-zivid
force-pushed
the
2026-05-28-update-python-samples
branch
6 times, most recently
from
9090136 to
21ee032
Compare
SatjaSivcev
force-pushed
the
2026-05-28-update-python-samples
branch
from
21ee032 to
d5abc82
Compare
SatjaSivcev
changed the title
When a capture raised a RuntimeError while the camera stayed connected, the exception handler only acted when an auto-run was in progress. A manually triggered capture that failed validation (for example invalid settings) was therefore swallowed: no dialog, no log, no change to the UI. The capture button appeared unresponsive even though the SDK had rejected the capture. This commit shows the error in a critical message box whenever a capture fails on a connected camera, so any capture-time error is visible to the user instead of being silently discarded. Also, the generated hand-eye settings always disabled Contrast Distortion Correction, while the engine selector defaulted to the Stripe Engine for every camera. On Zivid 2 the SDK requires Contrast Distortion Correction to be enabled with the Stripe Engine, so accepting the defaults produced settings the camera rejected on every capture. This commit enables Contrast Distortion Correction when the Stripe Engine is used on Zivid 2, so the generated settings are valid regardless of which engine is selected.
SatjaSivcev
force-pushed
the
2026-05-28-update-python-samples
branch
from
d5abc82 to
e520c7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a capture raised a RuntimeError while the camera stayed
connected, the exception handler only acted when an auto-run was in
progress. A manually triggered capture that failed validation (for
example invalid settings) was therefore swallowed: no dialog, no
log, no change to the UI. The capture button appeared unresponsive
even though the SDK had rejected the capture.
This commit shows the error in a critical message box whenever a
capture fails on a connected camera, so any capture-time error is
visible to the user instead of being silently discarded.
Also, the generated hand-eye settings always disabled Contrast
Distortion Correction, while the engine selector defaulted to the
Stripe Engine for every camera. On Zivid 2 the SDK requires Contrast
Distortion Correction to be enabled with the Stripe Engine, so accepting
the defaults produced settings the camera rejected on every capture.
This commit enables Contrast Distortion Correction when the Stripe
Engine is used on Zivid 2, so the generated settings are valid regardless
of which engine is selected.