Fix clash:// deep link not opening app due to premature Activity finish#1
Merged
xiwangly2 merged 1 commit intoziztechnology:round-screenfrom Apr 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When opening a clash://install-config?url=... deep link, the app would flash briefly or appear to not open at all.
Root Cause
In ExternalControlActivity.onCreate(), the ACTION_VIEW branch launches an async coroutine to create the profile and then start PropertiesActivity. However, after the when block, there is an unconditional return finish() at the end of onCreate(). Since launch {} returns immediately, the Activity was being destroyed before the coroutine completed — causing startActivity() to be called on an already-finished Activity.
Fix
Added a return statement after the launch {} block in the ACTION_VIEW branch to prevent execution from falling through to the premature finish(). The coroutine now manages the Activity lifecycle itself, calling finish() after startActivity() succeeds.