Conversation
…v history Fix #1: openComments in personal and space-files screens was routing to the heavier /v2/file screen. Since the preview overlay now has its own Comments tab (#149), wire the pill to PreviewOverlayService.open() with initialTab:'comments' instead. Extend PreviewOverlayService.open() with a PreviewOpenOptions param; PreviewComponent reads overlay.initialTab on each path change and auto-opens the info aside when comments is requested. Fix #2: file-detail.component.ts goTo() lacked replaceUrl:true, so each Prev/Next click pushed a new history entry. Close() called history.back() once, leaving the user stuck walking through stacked file-detail entries. Add replaceUrl:true so Prev/Next mutates the URL in place; Close exits in one click regardless of how many siblings were navigated. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix feat(fork): scaffolding for fork maintenance #1 — comments pill now opens the preview overlay (personal + space-files screens):
openCommentswas routing to the heavier/v2/filefull-screen route. Since the preview overlay gained its own Comments tab in mod(v2): preview — restore pdf.js, add comments tab, breathe spacing #149, the pill now callsPreviewOverlayService.open(path, file, { initialTab: 'comments' }).PreviewOverlayServicegets a newPreviewOpenOptionsparam + a plaininitialTabgetter;PreviewComponentreads that getter on each path change and auto-opens the info aside whencommentsis requested.Fix fix(ci): drop linux/arm64 build, keep amd64 only #2 — Prev/Next in file-detail no longer stacks history entries:
goTo()was missingreplaceUrl: true, so each sibling navigation pushed a new browser history entry.close()only walked back one entry, forcing the user to click Close once per Prev/Next pressed. AddingreplaceUrl: truemakes Prev/Next mutate the URL in place; Close exits in a single click.Files changed
preview-overlay.service.tsPreviewOpenOptionsinterface,initialTabgetter, extendopen()signaturepreview.component.tsoverlay.initialTabon each path change; auto-open info aside for commentspersonal.component.tsopenComments→ overlay withinitialTab: 'comments'space-files.component.tsfile-detail.component.tsgoTo()+replaceUrl: trueTest plan
/v2/personal→ preview overlay opens with Comments tab active and info aside expanded/v2/spaces/<alias>/v2/file?path=…(direct deep-link), click Next/Prev several times → URL mutates, Close exits in a single clickng lintandtsc --noEmitpass (verified locally)🤖 Generated with Claude Code