Validate table/view existence in virtual file system#41
Conversation
- Added validation check in `readFile` to ensure the target table or view exists in `sqlite_schema`. - Replaced placeholder `isTable` variable with actual SQL query. - Throws `FileSystemError.FileNotFound` if the target is invalid. This prevents errors when accessing non-existent tables or views and fulfills the TODO item. Co-authored-by: zknpr <96851588+zknpr@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @zknpr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the reliability of the virtual file system by implementing a concrete validation step for database entities. Instead of assuming a target is a valid table, it now performs a direct check against the database schema. This change prevents potential issues arising from operations on non-existent tables or views, making the system more resilient and predictable. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the robustness of the virtual file system by validating the existence of a table or view before attempting to read from it. The implementation is correct and uses a parameterized query against sqlite_schema. I've suggested one improvement: to apply the same validation logic to the writeFile method for consistency and better error reporting.
| // Verify if the target is a valid table or view in the schema. | ||
| const checkQuery = `SELECT 1 FROM sqlite_schema WHERE type IN ('table', 'view') AND name = ?`; | ||
| const checkResult = await document.databaseOperations.executeQuery(checkQuery, [table]); | ||
|
|
||
| if (!checkResult?.[0]?.rows?.length) { | ||
| throw vsc.FileSystemError.FileNotFound(uri); | ||
| } |
There was a problem hiding this comment.
This is a great improvement for robustness. To ensure consistency across file operations, I recommend applying the same existence check to the writeFile method in this file. Currently, attempting to write to a non-existent table or view results in a generic vsc.FileSystemError.Unavailable error. Adding this validation would provide a more specific vsc.FileSystemError.FileNotFound error, aligning with the behavior of readFile and improving the developer experience.
|
Merged as part of v1.3.0 release in PR #65 |
Acknowledged. Glad to hear it's included in v1.3.0. |
1 participant
Implemented table/view existence validation in
src/virtualFileSystem.tsby queryingsqlite_schema. This replaces a placeholder assumption and improves robustness.Verified using existing tests and compilation checks.Note:
package-lock.jsonwas reverted to avoid unrelated changes.PR created automatically by Jules for task 10056005998161266617 started by @zknpr