Skip to content

Add unit tests for SQLiteFileSystemProvider.writeFile#53

Closed
zknpr wants to merge 1 commit intomainfrom
testing-improvement-file-system-provider-12571903002749966063
Closed

Add unit tests for SQLiteFileSystemProvider.writeFile#53
zknpr wants to merge 1 commit intomainfrom
testing-improvement-file-system-provider-12571903002749966063

Conversation

@zknpr
Copy link
Copy Markdown
Owner

@zknpr zknpr commented Feb 7, 2026

Implemented unit tests for SQLiteFileSystemProvider.writeFile by mocking the vscode module using tsconfig paths. This verifies correct data handling (text vs binary) and error conditions.


PR created automatically by Jules for task 12571903002749966063 started by @zknpr

Introduces unit tests for `SQLiteFileSystemProvider.writeFile` to improve test coverage for core file system operations.

- Created `tests/mocks/vscode.ts` to mock `vscode` module dependencies (`Uri`, `FileSystemError`, etc.).
- Created `tsconfig.test.json` to map `vscode` imports to the mock implementation during tests.
- Added `tests/unit/virtualFileSystem.test.ts` covering:
  - Happy path for text content updates.
  - Handling of binary content (invalid UTF-8).
  - Error handling for invalid Row IDs and permission checks (`__create__.sql`).
- Updated `package.json` test script to use `tsconfig.test.json` for all unit tests.

This enables testing of `src/virtualFileSystem.ts` which was previously untestable due to direct `vscode` imports.

Co-authored-by: zknpr <96851588+zknpr@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sq-lite-explorer Ready Ready Preview, Comment Feb 7, 2026 2:01pm

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@zknpr
Copy link
Copy Markdown
Owner Author

zknpr commented Feb 7, 2026

Merged as part of v1.3.0 release in PR #65

@zknpr zknpr closed this Feb 7, 2026
@google-labs-jules
Copy link
Copy Markdown
Contributor

Merged as part of v1.3.0 release in PR #65

Acknowledged. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant