Conversation
Refactored the data grid and other UI components to eliminate the need for 'unsafe-inline' in the Content Security Policy style-src directive. Key changes: - Removed `cspUtil.inlineStyle` from `src/editorController.ts`. - Replaced inline styles with CSS classes in `core/ui/modules/grid.js` and `core/ui/modules/ui.js`. - Replaced inline styles with CSS classes in `core/ui/viewer.template.html`. - Added new utility classes to `core/ui/viewer.css` to support the changes. - Updated `package-lock.json` to match `package.json` version (1.2.7). Co-authored-by: zknpr <96851588+zknpr@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Merged as part of v1.3.0 release in PR #65 |
Acknowledged. |
1 participant
This change removes the requirement for
'unsafe-inline'styles in the Content Security Policy (CSP).Previous implementation relied on inline styles for dynamic layout in the data grid and various UI elements. This has been refactored to use:
viewer.css.grid.jsare applied viaelement.style.property = value, which is allowed by CSP 'self' and does not require'unsafe-inline'.Verified by:
npm test).npm run compile).PR created automatically by Jules for task 6052571533312156332 started by @zknpr