Skip to content

Sweep: Define interface for sql.js prepared statements#60

Closed
zknpr wants to merge 1 commit intomainfrom
refactor/wasm-db-types-1782077784216029526
Closed

Sweep: Define interface for sql.js prepared statements#60
zknpr wants to merge 1 commit intomainfrom
refactor/wasm-db-types-1782077784216029526

Conversation

@zknpr
Copy link
Copy Markdown
Owner

@zknpr zknpr commented Feb 7, 2026

This PR addresses a code health issue by replacing the unsafe any return type for prepare() in src/core/sqlite-db.ts with a proper WasmPreparedStatement interface.

Changes:

  • Defined WasmPreparedStatement interface with methods run, get, step, reset, free, and getColumnNames.
  • Updated WasmDatabaseInstance to use WasmPreparedStatement.
  • Updated WasmDatabaseEngine implementation to handle the typed statement object, including proper handling of get() return values (which can be undefined).
  • Added tests/unit/api_coverage.test.ts to verify the behavior of fetchTableData and updateCellBatch which rely on the prepared statement API.

Verification:

  • npm run compile passes.
  • npm test passes, including existing tests and the new API coverage tests.
  • Confirmed that get() behavior aligns with sql.js (returns row array or undefined).

PR created automatically by Jules for task 1782077784216029526 started by @zknpr

- Defined `WasmPreparedStatement` interface matching sql.js API
- Updated `WasmDatabaseInstance.prepare` to return `WasmPreparedStatement`
- Refactored `WasmDatabaseEngine` methods (`fetchTableData`, `updateCellBatch`) to use the new interface
- Added API coverage tests for `fetchTableData` and `updateCellBatch`

Co-authored-by: zknpr <96851588+zknpr@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sq-lite-explorer Ready Ready Preview, Comment Feb 7, 2026 2:22pm

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@zknpr
Copy link
Copy Markdown
Owner Author

zknpr commented Feb 7, 2026

Merged as part of v1.3.0 release in PR #65

@zknpr zknpr closed this Feb 7, 2026
@google-labs-jules
Copy link
Copy Markdown
Contributor

Merged as part of v1.3.0 release in PR #65

Acknowledged. Thank you for the update regarding the v1.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant