Conversation
Replaced `any[]` with `Transferable[]` in `src/core/rpc.ts` and `src/workerFactory.ts` to improve type safety for zero-copy transfers. Fixed a bug in `connectWorkerPort` usage where the transfer list was being ignored in `postMessage` calls. Added unit tests to verify `Transfer` wrapper and transfer list extraction. Co-authored-by: zknpr <96851588+zknpr@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Merged as part of v1.3.0 release in PR #65 |
🎯 What:
any[]withTransferable[]inTransferclass and RPC interfaces (MessageDispatcher,ResponseDispatcher).WorkerPortinterface andconnectWorkerPortimplementation to correctly type and passtransferarguments.src/workerFactory.tswhere thetransferargument was ignored in thepostMessageimplementation.tests/unit/rpc.test.tsto verifyTransferwrapper functionality and transfer list handling.💡 Why:
✅ Verification:
npm testto verify all tests pass, including the new RPC tests.Transferabletype is available and correct in the project environment.postMessageimplementations in both Browser and Node environments support the transfer list argument.✨ Result:
PR created automatically by Jules for task 17891390183586261492 started by @zknpr