Skip to content

🧹 Improve type safety in RPC transfer lists#64

Closed
zknpr wants to merge 1 commit intomainfrom
rpc-type-safety-transferable-17891390183586261492
Closed

🧹 Improve type safety in RPC transfer lists#64
zknpr wants to merge 1 commit intomainfrom
rpc-type-safety-transferable-17891390183586261492

Conversation

@zknpr
Copy link
Copy Markdown
Owner

@zknpr zknpr commented Feb 7, 2026

🎯 What:

  • Replaced any[] with Transferable[] in Transfer class and RPC interfaces (MessageDispatcher, ResponseDispatcher).
  • Updated WorkerPort interface and connectWorkerPort implementation to correctly type and pass transfer arguments.
  • Fixed a bug in src/workerFactory.ts where the transfer argument was ignored in the postMessage implementation.
  • Added a new test case in tests/unit/rpc.test.ts to verify Transfer wrapper functionality and transfer list handling.

💡 Why:

  • Improves type safety by preventing arbitrary objects from being passed as transferables, which would cause runtime errors.
  • Ensures zero-copy transfers actually work by fixing the bug where the transfer list was dropped.
  • Makes the code more maintainable and self-documenting regarding what data is expected.

Verification:

  • Ran npm test to verify all tests pass, including the new RPC tests.
  • Verified that Transferable type is available and correct in the project environment.
  • Verified that postMessage implementations in both Browser and Node environments support the transfer list argument.

Result:

  • Stronger type guarantees for RPC operations.
  • Fixed zero-copy transfer mechanism.

PR created automatically by Jules for task 17891390183586261492 started by @zknpr

Replaced `any[]` with `Transferable[]` in `src/core/rpc.ts` and `src/workerFactory.ts` to improve type safety for zero-copy transfers.
Fixed a bug in `connectWorkerPort` usage where the transfer list was being ignored in `postMessage` calls.
Added unit tests to verify `Transfer` wrapper and transfer list extraction.

Co-authored-by: zknpr <96851588+zknpr@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sq-lite-explorer Ready Ready Preview, Comment Feb 7, 2026 3:14pm

@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@zknpr
Copy link
Copy Markdown
Owner Author

zknpr commented Feb 7, 2026

Merged as part of v1.3.0 release in PR #65

@zknpr zknpr closed this Feb 7, 2026
@google-labs-jules
Copy link
Copy Markdown
Contributor

Merged as part of v1.3.0 release in PR #65

Acknowledged. Thank you for the update regarding the v1.3.0 release and PR #65. I'm glad the improvement is being included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant