docs: add seller guide for vault delegation#89
Merged
ADWilkinson merged 3 commits intomainfrom Apr 29, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
Field Report
✅ All clear — no findings across any operative. Field report by oneshot-bot — 5 specialist operatives, cross-validated by arbiter |
ADWilkinson
commented
Apr 28, 2026
Contributor
Author
ADWilkinson
left a comment
ADWilkinson
left a comment
There was a problem hiding this comment.
[PAPERCLIP-APPROVED]
LGTM. Verified:
- Scope matches spec: only
guides/for-sellers/delegate-to-a-vault.md(new) andguides-sidebars.jstouched;.oneshot-pr-*.txtare pipeline artifacts. - Sidebar entry placed correctly between
for-sellers/manual-releasesandfor-sellers/notifications(guides-sidebars.js:30). - UI labels verified verbatim against zkp2p-clients source:
Delegate to Vault,DELEGATE TO VAULT,DELEGATING...,PREPARING VAULT...,VIEW DEPOSIT,Delegated,Vault delegation failed,Deposit created. Vault delegation unavailable,Delegate to vault,Delegating...,No compatible vaults— all match ExpressMode.tsx, AdvancedMode.tsx, VaultDelegationPanel.tsx. - Tip quote matches VaultDelegationCTA.tsx:50-51 verbatim.
phase3VaultsEnabledgating called out explicitly.- Cross-links resolve:
automated-rate-management.md,notifications.md,for-vault-managers/index.md. - Vercel build SUCCESS, no broken-link warnings.
Ready for merge.
ADWilkinson
force-pushed
the
oneshot/closes-zkp2p-docs-88-what-to-change-add--1777363981091
branch
from
712de84 to
db8643c
Compare
ADWilkinson
deleted the
oneshot/closes-zkp2p-docs-88-what-to-change-add--1777363981091
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
guides/for-sellers/delegate-to-a-vault.mdcovering what vault delegation does, how to enable it, how to choose a vault, and post-deposit states.guides-sidebars.jsaftermanual-releasesand beforenotificationsin the For Sellers section.zkp2p-clientssource (ExpressMode, AdvancedMode, VaultDelegationPanel, VaultDelegationCTA).Why
Vault delegation shipped in zkp2p-clients commit 10f00f53 (2026-04-27) with zero docs coverage. Sellers need a reference for enabling delegation, choosing a vault, and understanding post-deposit follow-up states.
Closes #88
Changes
guides/for-sellers/delegate-to-a-vault.md— New doc covering: what delegation does (with verbatim tip quote), who it's for (cross-link to ARM), toggle location (Express + Advanced, phase flag note), vault selection (sort tabs, pagination, card metrics, empty state), post-deposit states (Express and Advanced CTA labels, success/unavailable/error states), and next steps (vaults page, vault manager guide).guides-sidebars.js— Addedfor-sellers/delegate-to-a-vaultto the For Sellers items array betweenmanual-releasesandnotifications.Test plan
yarn build— succeeded with zero broken-link warnings.