Fix #548#559
Merged
Merged
Conversation
| return nil, nil, StatusIllegalInput, err | ||
| // q.Name is a valid name, we can continue | ||
| if err != nil { | ||
| if !util.IsStringValidDomainName(q.Name) { |
Contributor
There was a problem hiding this comment.
Seems like a good fix, the only thing I don't love is it's a bit hard to reason about the case where err != nil but util.IsStringValidDomainName == true. In that case, we skip the else which might not be best.
I'm thinking this will be flatter logically and thus easier to read
if err != nil && !util.IsStringValidDomainName(q.Name) {
return nil, nil, StatusIllegalInput, err
} else if len(qname) > 0 && qname[len(qname)-1] == '.' {
// remove trailing "." added by dns.ReverseAddr
q.Name = qname[:len(qname)-1]
}If you agree, I'll make the fix. Tested it with the sample input and looks good 👍
Member
Author
There was a problem hiding this comment.
Sure! I don't have a strong opinion on the logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug where we don't handle inputs like
8.8.8.8.in-addr.arpacorrectly in the PTR module.Resolves #548