Fix broken integration test#581
Merged
Merged
Conversation
zakird
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like
example.comupdated their nameservers to use Cloudflare.dig -t NS example.com @hera.ns.cloudflare.com ... ;; ANSWER SECTION: example.com. 86400 IN NS elliott.ns.cloudflare.com. example.com. 86400 IN NS hera.ns.cloudflare.com.This breaks the integration test where I wanted to test resolving domains whose nameservers were in a different zone as themselves.
tripadvisor.deseems to be a good alternative. Using AWS's DNS, their nameservers sit across 4 zones. I remove explicit checks for what those nameservers are, since I'd imagine that could change with these being cloud DNS providers and I don't want our tests to be brittle.$ dig -t A tripadvisor.de @a.nic.de ;; AUTHORITY SECTION: tripadvisor.de. 86400 IN NS ns-1710.awsdns-21.co.uk. tripadvisor.de. 86400 IN NS ns-1014.awsdns-62.net. tripadvisor.de. 86400 IN NS ns-463.awsdns-57.com. tripadvisor.de. 86400 IN NS ns-1296.awsdns-34.org.