[check_manfile.py] Fix file handle leak#967
Merged
Merged
Conversation
When rdlength is 0, the code would: 1. xmalloc(0) allocates a zero-size buffer 2. memcpy(txt, rdata + 1, rdlength - 1) underflows uint16_t to 65535 3. Writing ~64KB to a 0-byte buffer causes heap corruption Add explicit rdlength==0 check before the TXT parsing logic. Fixes zmap#962
zakird
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check_manfile.pyline 29open()call for the ronn file was not using a context managerFix
open()call in awithstatement to ensure proper resource cleanup