Skip to content

V2#145

Merged
strideynet merged 54 commits intomasterfrom
v2
Aug 16, 2021
Merged

V2#145
strideynet merged 54 commits intomasterfrom
v2

Conversation

@strideynet
Copy link
Collaborator

@strideynet strideynet commented Jan 17, 2021

V2 should include the following breaking changes:

  • context.Context support
  • support for instantiation of the library with a custom HTTP client (without using our auth)
  • support for functional options rather than config structs for list endpoints

Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
@strideynet
Copy link
Collaborator Author

Hey @zmb3 , having some general thoughts that might be easier to discuss in IRC/Slack/Discord. Is there any platforms I can reach you on?

@zmb3
Copy link
Owner

zmb3 commented Jan 26, 2021

@strideynet you bet. I’m @zmb3 on Gophers slack.

Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
@zmb3
Copy link
Owner

zmb3 commented Jan 27, 2021

@strideynet we should remove the AppVeyor CI as part of this work too. The Github actions are easier to maintain and we really don't do anything OS-specific so AppVeyor's Windows support is not adding vaue.

@strideynet
Copy link
Collaborator Author

@zmb3 Yeah! I can't find the config for that, but Github Actions is much better integrated with github.

@zmb3
Copy link
Owner

zmb3 commented Jan 27, 2021

I deleted it from AppVeyor, so we just need to remove the badge from the README, and might as well delete the .travis.yml file too.

Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
Signed-off-by: Noah Stride <noah@noahstride.co.uk>
@strideynet
Copy link
Collaborator Author

I've updated the Authenticator New() to take functional options as well. This stops the redundant empty string values when using Client Credentials or PKCE.

Signed-off-by: Noah Stride <noah@noahstride.co.uk>
@strideynet strideynet requested a review from zmb3 April 8, 2021 17:03
@conradludgate
Copy link
Contributor

I'd love to start using this in my project but I would like to wait for it to be merged first. Can I help in anyway?

@strideynet
Copy link
Collaborator Author

@conradludgate, I'm actually hoping to do some work on this tomorrow. I'll let you know then if theres anything that comes to mind.

@strideynet strideynet marked this pull request as ready for review August 15, 2021 17:04
@strideynet strideynet merged commit c44aaf9 into master Aug 16, 2021
@strideynet strideynet deleted the v2 branch August 16, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants