fix(action): drop broken author URL on direct-push stories#2
Merged
Conversation
Closes #1 Direct-push commits had no associated PR, so we fell back to constructing a GitHub URL from the git committer name: https://github.com/${encodeURIComponent(commit.authorName)} Committer names are display names ("Nathan Zylbersztejn"), not GitHub handles — the resulting URL 404s. Drop the URL entirely for direct-push commits; the StoryCard already has a fallback path that renders the name as plain text when authorUrl is undefined. PR-merge stories continue to work — pr.authorUrl comes from GraphQL's verified pr.author.url.
This was referenced May 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
What changes
Direct-push commits had no associated PR, so the analyzer fell back to constructing a GitHub URL from the git committer name:
```
https://github.com/Nathan%20Zylbersztejn
```
That 404s. Committer names are display names, not GitHub handles, and we have no reliable mapping without an additional GraphQL email→user lookup.
This PR drops the constructed URL entirely for `kind: 'direct-push'` stories. The `StoryCard` already has a fallback that renders the byline as plain text when `authorUrl` is missing, so no UI changes are needed.
PR-merge stories are unaffected — `pr.authorUrl` comes from GraphQL's verified `pr.author.url` and continues to render as a working link.
Test plan