fix(self-deploy): track publish-pages.yaml@main (immediate fix unblock)#40
fix(self-deploy): track publish-pages.yaml@main (immediate fix unblock)#40
Conversation
self-deploy was stuck failing because it pinned publish-pages.yaml@v0 (currently floating to v0.1.4) which still has the broken npx form. Workflow/README fixes don't bump the cli package, so v0 won't advance on its own without a cli-touching commit. Since self-deploy is gitpulse's own dogfood (not the external consumer surface), tracking @main is fine — we get the fix immediately and stay on bleeding-edge by definition. External consumers continue pinning @v0 / @v1 for stability; their experience is unaffected. Could revert to @v0 after a cli-touching change ships and floats v0 forward, but there's no strong reason to. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesWorkflow Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
| Filename | Overview |
|---|---|
| .github/workflows/self-deploy.yml | Single-line change unpins the reusable workflow reference from @v0 to @main; intentional trade-off acknowledged in PR description |
Sequence Diagram
sequenceDiagram
participant Push as Push to main
participant SelfDeploy as self-deploy.yml
participant PublishPages as publish-pages.yaml@main
participant CLI as npx @gitpulse/cli@0
participant Pages as GitHub Pages
Push->>SelfDeploy: trigger (push/release/dispatch)
SelfDeploy->>PublishPages: uses (was @v0, now @main)
PublishPages->>CLI: npm install -g @gitpulse/cli@0
CLI->>CLI: analyze + build
CLI->>Pages: deploy artifact
Reviews (1): Last reviewed commit: "fix(self-deploy): track publish-pages.ya..." | Re-trigger Greptile
self-deploy is the only red workflow left; deploy-vercel just went green on
8a27e8dwith the npm install -g fix.self-deploy fails because it pins
publish-pages.yaml@v0andv0floats tov0.1.4— which has the brokennpxform. The fix on main only affects publish-pages.yaml's content, but workflow files don't bump the cli package, so release-please won't propose a 0.1.5 release that would float v0 forward.This PR: self-deploy →
publish-pages.yaml@main. Picks up the fix immediately on next push, stays evergreen.Trade-off: self-deploy is no longer pinned. Acceptable because:
@v0/@v1for stability🤖 Generated with Claude Code
Summary by CodeRabbit