shorter output when option is incorrect#214
Merged
vlevigneron merged 2 commits intozonemaster:developfrom Jul 30, 2021
Merged
Conversation
matsduf
requested changes
Jul 30, 2021
Contributor
matsduf
left a comment
matsduf
left a comment
There was a problem hiding this comment.
How do I run a test?
# zonemaster-cli iis.se
Unknown option: iis.se
Run "zonemaster-cli -h" to get the valid options
Contributor
Author
|
@matsduf it seems I have been too fast to conclude it works... |
Contributor
Author
|
@matsduf It should be OK now |
matsduf
approved these changes
Jul 30, 2021
Contributor
|
This is an improvement. Is it possible to make "-h" output the equivalent of |
Contributor
Author
|
Yes this is part of #68, I'll check what is possible to do. |
hannaeko
added
the
S-ReleaseTested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR does no longer display full usage in case of incorrect option
Context
Fixes #160
Changes
Add 'pass_through' option to MooseX::Getopt::GLD prevents print of a systematic 'usage'.
How to test this PR
use invalid option(s), the output will look like