Cleanup in Syntax test module

[tgreenx]

Purpose

This PR proposes an update to the Syntax test module. See Changes section below.

Context

Fixes #1283 and #1274

Changes

• Remove internal helper function _get_name()
• Correct return value in Syntax08
• Correct POD typo in link for Syntax04

How to test this PR

Tests should pass.

Also, there should now be a TEST_CASE_END message for Syntax08 once it finishes:

$ zonemaster-cli --show-testcase --test=syntax --level=debug --no-ipv6 --raw 'zonemaster.net' | grep TEST_CASE_
   0.00 DEBUG    SYNTAX01       TEST_CASE_START   testcase=syntax01
   0.00 DEBUG    SYNTAX01       TEST_CASE_END   testcase=syntax01
   0.00 DEBUG    SYNTAX02       TEST_CASE_START   testcase=syntax02
   0.00 DEBUG    SYNTAX02       TEST_CASE_END   testcase=syntax02
   0.00 DEBUG    SYNTAX03       TEST_CASE_START   testcase=syntax03
   0.00 DEBUG    SYNTAX03       TEST_CASE_END   testcase=syntax03
   1.03 DEBUG    SYNTAX04       TEST_CASE_START   testcase=syntax04
   1.03 DEBUG    SYNTAX04       TEST_CASE_END   testcase=syntax04
   1.03 DEBUG    SYNTAX04       TEST_CASE_START   testcase=syntax04
   1.03 DEBUG    SYNTAX04       TEST_CASE_END   testcase=syntax04
   1.03 DEBUG    SYNTAX04       TEST_CASE_START   testcase=syntax04
   1.03 DEBUG    SYNTAX04       TEST_CASE_END   testcase=syntax04
   1.03 DEBUG    SYNTAX04       TEST_CASE_START   testcase=syntax04
   1.03 DEBUG    SYNTAX04       TEST_CASE_END   testcase=syntax04
   1.03 DEBUG    SYNTAX05       TEST_CASE_START   testcase=syntax05
   1.03 DEBUG    SYNTAX05       TEST_CASE_END   testcase=syntax05
   1.03 DEBUG    SYNTAX06       TEST_CASE_START   testcase=syntax06
   1.46 DEBUG    SYNTAX06       TEST_CASE_END   testcase=syntax06
   1.46 DEBUG    SYNTAX07       TEST_CASE_START   testcase=syntax07
   1.46 DEBUG    SYNTAX07       TEST_CASE_END   testcase=syntax07
   1.46 DEBUG    SYNTAX08       TEST_CASE_START   testcase=syntax08
   1.47 DEBUG    SYNTAX08       TEST_CASE_END   testcase=syntax08

[marc-vanderwal]

Release testing report – No issues found

Rocky Linux 9.3

Unit tests pass.

I can see, by reading the perldoc documentation for Zonemaster::Engine::Test::Syntax, that the link in the description of the syntax04 method is correct.

I also see that Syntax08 has a TEST_CASE_END message. I get a slightly different output than what is shown in the testing procedure: test case names have the form Syntax<number> instead of SYNTAX<number>. I assume this is a side-effect of merging #1302.