Total refactor of mset9.py #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Why did you mark this as ready for review? It is still a work in progress until as many bugs as possible are ironed out. |
Owner
|
I've received dozens of pull requests in the time I've been on Github and I've never seen a draft/review type before. So I thought "Review" meant 'go over the changes and approve before merging' as if that was something that I was obligated to do. |
Contributor
Author
|
Ah, not a problem! It will likely be ready shortly, I'll make sure to mention you when it is ready. |
Contributor
Author
|
Seems like blueness ironed out all of the bugs after like 4 rounds of pounding it into the ground. I believe the script is ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors most of the script, and makes it far easier to diagnose problems. It is currently a work in progress.