PR 343 review #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove trailing space Unify file format (Unix) Add STM Morpho connector pin mapping Clean up some comments Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
Author
|
Merci |
Owner
|
I agree, of course, and merged it but I don't know how to force update to my branch! |
Author
|
No worries, I will squash the 3 commits in one when I will merge your PR. ;) |
Owner
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zoomx
I've made a quick review and do some update:
If you are agreed, could you squash all your commits for the L073 and this one into one commit then force update to your branch to update stm32duino#343
Thanks