Merged
Conversation
Enable native arm64 support for Apple Silicon users by building multi-architecture images via buildx. Uses TARGETARCH for explicit Go cross-compilation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Required for arm64 emulation on amd64 runners. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace QEMU emulation with native cross-compilation by adding --platform=$BUILDPLATFORM to the build stage. Go cross-compiles to the target architecture natively, eliminating slow emulation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- actions/checkout v4 → v6 - actions/setup-go v4 → v6 (caching now enabled by default) - golangci/golangci-lint-action v8 → v9 - Add step to output pushed image registry path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add config file hydration and update README
aryanmehrotra
requested changes
Mar 9, 2026
|
|
||
| const filePathVar = "CONFIG_FILE_PATH" | ||
|
|
||
| func HydrateFile(fs file.FileSystem, cfg config.Config) error { |
Contributor
There was a problem hiding this comment.
config should not be sent here, we should read in main.go and inject the key value pairs, config.Config should not be the dependency.
Contributor
There was a problem hiding this comment.
We can also add a comment of why this is being done is because we are doing something which is not recommended and we also need to make sure we don't follow this elsewhere and it was done here because this is the cleanest way as of now.
aryanmehrotra
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config File Hydration
When the
CONFIG_FILE_PATHenvironment variable is set, the server replaces any${VAR}placeholders in that file at startup using values from the environment (including.envfiles). The file is rewritten in-place before serving begins.This is useful for injecting runtime configuration into static front-end apps without rebuilding them.
If any placeholders have no matching environment variable, the server still writes the file (substituting empty strings for missing values) and logs an error listing the unresolved variables.