-
Notifications
You must be signed in to change notification settings - Fork 42
Python3 update #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I appreciate the work of migrating all the old unittests, but merging them right now is a bit too early from my point of view. After this merge the test framework fails. So how should I know if new changes break existing code ? I thought the strategy is adding checks/protections + their tests step by step and always having a green bar. |
|
@oz123 As @stephan-hof said: Thank you for your hard work in porting the tests. But now tests for each Python version are broken. So I have to revert the merge. Please split it up in smaller parts and make sure the test run successfully using |
|
@icemac sorry for the late reply. No problem with the revert. I will see that I can port the tests in smaller chunks. |
|
Hi together, sorry for the late answer, I just arrived yesterday from PloneConf2016 in Boston and had directly to attend meeting sin the office. @oz123 was working with me at the PloneConf2016 on porting additional Tests and features of RestrictedPython he did a Pull Request before I leave and asked me to review what I didn't had the chance to. @icemac and @stephan-hof are right, that shouldn't have been merged already. It would be good if we could revert and and than reapply test and feature one by one, so that after all everybody could work on an green build. @oz123 might you at the moment please revert and keep your branch, and at the PyCon.DE we might could work on and spiltt and merge all of it step by step. |
@loechel still WIP ... Check the changes done. I hope this helps.