Increase test coverage of Guards to 100%. #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis-ci errors will be fixed by another pull request by icemac. |
icemac
requested changes
Sep 13, 2017
tests/test_Guards.py
Outdated
| __metaclass__=type, | ||
| _write_=lambda x: x, | ||
| _getattr_=getattr) | ||
| _getattr_=getattr,) |
tests/test_Guards.py
Outdated
| assert restricted_globals['b'] == '2411' | ||
|
|
||
|
|
||
| class D: |
There was a problem hiding this comment.
The classes should have more meaningful values. If the are only needed for one test they could be moved into the test function together with the code which uses them.
tests/test_Guards.py
Outdated
| assert None is restricted_globals['d1'].value | ||
|
|
||
|
|
||
| class E: |
tests/test_Guards.py
Outdated
| assert 'attribute-less object (assign or del)' in str(excinfo.value) | ||
|
|
||
|
|
||
| class F: |
tests/test_Guards.py
Outdated
| def test_Guards__safe_builtins__3(e_exec): | ||
| """It allows use setattr and delattr when _guarded_writes is True. | ||
| `__build_class__` is only needed in Python 3. |
There was a problem hiding this comment.
I do not see any __build_class__ usage in this test.
tests/test_Guards.py
Outdated
|
|
||
|
|
||
| @pytest.mark.parametrize(*e_exec) | ||
| def test_Guards__safe_builtins__3(e_exec): |
There was a problem hiding this comment.
I think it should be called test_Guards__guarded_setattr__1 as it actually tests guarded_setattr.
|
|
||
| @pytest.mark.parametrize(*e_exec) | ||
| def test_Guards__safe_builtins__3(e_exec): | ||
| """It allows use setattr and delattr when _guarded_writes is True. |
There was a problem hiding this comment.
The delattr test could be moved to another test function.
tests/test_Guards.py
Outdated
|
|
||
| @pytest.mark.parametrize(*e_exec) | ||
| def test_Guards__write_wrapper__1(e_exec): | ||
| """It wraps it when it is not marked with _guarded_writes.""" |
tests/test_Guards.py
Outdated
|
|
||
| @pytest.mark.parametrize(*e_exec) | ||
| def test_Guards__write_wrapper__2(e_exec): | ||
| """It wraps it and it works when guarded_setattr is implemented.""" |
tests/test_Guards.py
Outdated
| @pytest.mark.parametrize(*e_exec) | ||
| def test_Guards__guarded_unpack_sequence__1(e_exec, mocker): | ||
| """It does not protect unpacking when the sequence is shorter | ||
| than expected.""" |
There was a problem hiding this comment.
The comment should explain why this is okay.
icemac
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.