Increase buffer size used for GitHub token.#139
Merged
MikeFultonDev merged 2 commits intozopencommunity:mainfrom Jan 25, 2023
Merged
Increase buffer size used for GitHub token.#139MikeFultonDev merged 2 commits intozopencommunity:mainfrom
MikeFultonDev merged 2 commits intozopencommunity:mainfrom
Conversation
According to https://github.blog/changelog/2021-03-31-authentication-token-format-updates-are-generally-available/ a GitHub token can be aup to 255 characters in length. The current temporary buffer has size 80, which is too small. This PR changes the size to 280 (255 for the token, 20 for Authorization:Bearer, and a couple of spare bytes.
redstar
requested review from
IgorTodorovskiIBM and
MikeFultonDev
as code owners
Collaborator
MikeFultonDev
left a comment
MikeFultonDev
left a comment
There was a problem hiding this comment.
can you either add a comment on why the magic 280 or alternately do the math in the array, e.g.
char buf[255+...] with a comment (and ideally a pointer to the github link).
Contributor
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the GitHub blog a GitHub token can be aup to 255 characters in length. The current temporary buffer has size 80, which is too small.
This PR changes the size to 280 (255 for the token, 20 for Authorization:Bearer, and a couple of spare bytes).