Move setup.sh to end of .env so that you can use envars in setup.sh#144
Merged
IgorTodorovskiIBM merged 2 commits intomainfrom Jan 29, 2023
Merged
Move setup.sh to end of .env so that you can use envars in setup.sh#144IgorTodorovskiIBM merged 2 commits intomainfrom
IgorTodorovskiIBM merged 2 commits intomainfrom
Conversation
MikeFultonDev
approved these changes
Jan 29, 2023
Collaborator
MikeFultonDev
left a comment
MikeFultonDev
left a comment
There was a problem hiding this comment.
I think it’s good - can you check that the append-to-setup works ok still?
Member
Author
Just noticed "Setup completed" is emitted before that, so I'll fix that up. |
Member
Author
|
Ok looks good now, tested with gitport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.