Skip to content

Various zopen-build Improvements#169

Merged
IgorTodorovskiIBM merged 2 commits intomainfrom
improvements
Feb 10, 2023
Merged

Various zopen-build Improvements#169
IgorTodorovskiIBM merged 2 commits intomainfrom
improvements

Conversation

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member

  • Doing dir=$(gitClone), doesnt allow gitClone to have any side effects on the variables, so setting forceRebuild=true had no effect.
    • Since we set dir within gitClone and downloadTarBall, we don't have to set it to the return value, it's already set.
  • Fixes various issues with deleteDuplicateEntries
  • Also sorts + uniqs the builddeps and runtime dependencies

Comment thread bin/lib/zopen-build

_CEE_RUNOPTS="\$_CEE_RUNOPTS FILETAG(AUTOCVT,AUTOTAG) POSIX(ON)"
# Remove spaces in between brackets
_CEE_RUNOPTS="\$(echo "\$_CEE_RUNOPTS" | awk '{gsub(/\([ \t]*/, "("); gsub(/[ \t]*\)/, ")"); gsub(/[ \t]*,[ \t]*/, ","); print}')"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ok for now, but some runtime options have strings that you wouldn't want to remove spaces from

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, USRHDLR(lmname,"") seems to be one example. As long as there is not comma or () within the quotes, then it should be ok.

Copy link
Copy Markdown
Collaborator

@MikeFultonDev MikeFultonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - note my one comment

@IgorTodorovskiIBM IgorTodorovskiIBM merged commit 0fce42b into main Feb 10, 2023
@MikeFultonDev MikeFultonDev deleted the improvements branch March 19, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants