Skip to content

Add curl to the path when we run zopen install#225

Merged
IgorTodorovskiIBM merged 2 commits intomainfrom
fix_curl
Mar 9, 2023
Merged

Add curl to the path when we run zopen install#225
IgorTodorovskiIBM merged 2 commits intomainfrom
fix_curl

Conversation

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Collaborator

@MikeFultonDev MikeFultonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Comment thread bin/lib/zopen-build Outdated
setDepsEnv()
{
if $forceUpgradeDeps; then
if type curl; then
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t you need to redirect stderr and stdout here to avoid stuff getting written to the screen?

Copy link
Copy Markdown
Collaborator

@MikeFultonDev MikeFultonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@IgorTodorovskiIBM IgorTodorovskiIBM merged commit 14d403c into main Mar 9, 2023
@MikeFultonDev MikeFultonDev deleted the fix_curl branch March 19, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants