Skip to content

Modify zopen-build to generate the .depsenv rather than zopen-install#334

Merged
IgorTodorovskiIBM merged 1 commit intomainfrom
build_gen_depsenv
Jun 16, 2023
Merged

Modify zopen-build to generate the .depsenv rather than zopen-install#334
IgorTodorovskiIBM merged 1 commit intomainfrom
build_gen_depsenv

Conversation

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member

Reasons for doing this:

  • sourcing of .depsenv is currently appended via the zopen-install, but this is an issue if we want to use the variables or tools from the dependencies in the setup.sh script.
    The current flow is: (program is sourced)->(setup.sh is run)->(dependencies are sourced)
    The new flow will be (program is sourced)->(dependencies are sourced)->(setup.sh is run)
  • It will also allow individual .pax.Z downloads to potentially pick up dependencies

Copy link
Copy Markdown
Collaborator

@MikeFultonDev MikeFultonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite understanding. Can you provide an example where this solves a problem?

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member Author

I am not quite understanding. Can you provide an example where this solves a problem?

This resolves an issue with gpg, where it depends on pinentry and needs to know the path of pinentry-tty at setup.sh time.

Copy link
Copy Markdown
Collaborator

@MikeFultonDev MikeFultonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@IgorTodorovskiIBM IgorTodorovskiIBM merged commit 51c64cf into main Jun 16, 2023
@IgorTodorovskiIBM IgorTodorovskiIBM deleted the build_gen_depsenv branch September 15, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants