Skip to content

add example for open() and tagging#41

Merged
MikeFultonDev merged 2 commits intomainfrom
copen-troubleshooting
Sep 13, 2022
Merged

add example for open() and tagging#41
MikeFultonDev merged 2 commits intomainfrom
copen-troubleshooting

Conversation

@MikeFultonDev
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Member

@IgorTodorovskiIBM IgorTodorovskiIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeFultonDev MikeFultonDev added the documentation Improvements or additions to documentation label Sep 12, 2022
Copy link
Copy Markdown
Collaborator

@ejratl ejratl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. As a person without a zOS background, the two things that I would like to have further explained are 1) the 819 == ASCII relationship (where do I look this up) and 2) (related but orthogonal to the goal here) a quick hint about whether files can be tagged from the command line, once they have been created without the tagging (this will help me decide how to more forward once I have fixed the issue).

Also, Markdown linters really want blank lines before and after code segments.

Copy link
Copy Markdown
Collaborator

@ejratl ejratl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exceptionally helpful for people like me with an open source rather than an IBM z background. Thanks for adding this additional information, since I will have to use it for the port that I am working on.

@MikeFultonDev MikeFultonDev merged commit d807131 into main Sep 13, 2022
@MikeFultonDev MikeFultonDev deleted the copen-troubleshooting branch September 13, 2022 01:35
IgorTodorovskiIBM pushed a commit that referenced this pull request Jan 11, 2023
Tag untracked files as well (new files created from patches)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants