zopen build install changes + fix for replacing hardcoded paths in package contents#415
Merged
IgorTodorovskiIBM merged 2 commits intomainfrom Sep 19, 2023
Merged
Conversation
MikeFultonDev
approved these changes
Sep 18, 2023
Collaborator
MikeFultonDev
left a comment
There was a problem hiding this comment.
An elegant solution I think!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discussing with @MikeFultonDev, we decided to change the zopen build install location back to
${ZOPEN_PKGINSTALL}/<pkg>/<pkg>instead of${ZOPEN_PKGINSTALL}/dev/<pkg>/<pkg>. This is so that we can leverage thezopen altlogic to optionally set the local build as the current release.Here's an example of zoslib.
Before zopen build:
After zopen build:
If the user does not want to set their local build as active, then they can add the option:
—no-set-activewill not affect the active versionThis also fixes the issue where hardcoded paths to the root directory are not replaced. Additionally, since the paths contains a timestamp, additional logic has been added to strip them away.
Note: https://github.com/ZOSOpenTools/meta/compare/zopen-build-install-changes?expand=1#diff-18d8a0f3b6e2204467238e541740a1e6b0092f69dcd8f83bbf3d94627f172e69R1202 - to ensure the replace hardcoded paths logic works, the path suffix is removed. For example, zoslib-zopen.20230914_230230.zos is modified to zoslib.