Skip to content

zopen build install changes + fix for replacing hardcoded paths in package contents#415

Merged
IgorTodorovskiIBM merged 2 commits intomainfrom
zopen-build-install-changes
Sep 19, 2023
Merged

zopen build install changes + fix for replacing hardcoded paths in package contents#415
IgorTodorovskiIBM merged 2 commits intomainfrom
zopen-build-install-changes

Conversation

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member

@IgorTodorovskiIBM IgorTodorovskiIBM commented Sep 17, 2023

After discussing with @MikeFultonDev, we decided to change the zopen build install location back to ${ZOPEN_PKGINSTALL}/<pkg>/<pkg> instead of ${ZOPEN_PKGINSTALL}/dev/<pkg>/<pkg>. This is so that we can leverage the zopen alt logic to optionally set the local build as the current release.

Here's an example of zoslib.

Before zopen build:

`: zoslib-zopen.20230914_230230.zos  <-  current

After zopen build:

1: zoslib-new_file_env  <-  current
2: zoslib-zopen.20230914_230230.zos
  • Additionally, we probably don’t need to change the ZOPEN_INSTALL_DIR naming logic because it doesn’t contain a timestamp, which means it will never conflict with official install paths.

If the user does not want to set their local build as active, then they can add the option:

  • —no-set-active will not affect the active version

This also fixes the issue where hardcoded paths to the root directory are not replaced. Additionally, since the paths contains a timestamp, additional logic has been added to strip them away.
Note: https://github.com/ZOSOpenTools/meta/compare/zopen-build-install-changes?expand=1#diff-18d8a0f3b6e2204467238e541740a1e6b0092f69dcd8f83bbf3d94627f172e69R1202 - to ensure the replace hardcoded paths logic works, the path suffix is removed. For example, zoslib-zopen.20230914_230230.zos is modified to zoslib.

Copy link
Copy Markdown
Collaborator

@MikeFultonDev MikeFultonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An elegant solution I think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants