Add checks to publish.groovy script#467
Merged
IgorTodorovskiIBM merged 1 commit intomainfrom Sep 28, 2023
Merged
Conversation
Member
IgorTodorovskiIBM
commented
Sep 27, 2023
IgorTodorovskiIBM
commented
- Sometimes the github release is not reflected in github immediately after the release is created, so I added a loop that checks up to 5 times.
- Also, sometimes the release doesn't actually end up being created, so I make a last resort attempt and try to recreate it.
- This should also fix an issue with multiple .version files appearing, so it only look at installed .version now.
IgorTodorovskiIBM
requested review from
DevonianTeuchter and
MikeFultonDev
as code owners
| echo "Release should now exist" | ||
| github-release info -u ${GITHUB_ORGANIZATION} -r ${GITHUB_REPO} --tag "${TAG}" -j | ||
| # check up to 5 times for the release to appear on github | ||
| for i in {1..5}; do |
Collaborator
There was a problem hiding this comment.
not sure how expensive the call is but would it better to go with maybe 2 seconds and do it 25 times?
if 10s is the 'sweet spot', then i am fine with this.
Member
Author
There was a problem hiding this comment.
From prior experience, it usually takes about 5-10s for the release to be reflected in github, so I'll stick with 10s for now and see how it goes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.