Skip to content

Provide the total size up front when installing all tools (zopen install --all)#564

Merged
IgorTodorovskiIBM merged 3 commits intomainfrom
size_for_all
Nov 15, 2023
Merged

Provide the total size up front when installing all tools (zopen install --all)#564
IgorTodorovskiIBM merged 3 commits intomainfrom
size_for_all

Conversation

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member

Output as of today:

You have chosen to install all tools. An estimated 2819.17 MB of additional disk space will be used.

Copy link
Copy Markdown
Collaborator

@DevonianTeuchter DevonianTeuchter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as-is but would a 'du' space check be a useful addition at this point to save failure during the install if insufficient space?

Copy link
Copy Markdown
Collaborator

@MikeFultonDev MikeFultonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if you haven't already, do you want to open an issue to handle the size calculation for a set of packages (as opposed to all)?

@MikeFultonDev
Copy link
Copy Markdown
Collaborator

i like that. i also think if there is less than XX MB in the file system, we should just fail too... If it's close enough to empty, they should clean up.

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member Author

I like the idea as well! However, I think some filesystems are set up such that they can grow once they reach the max quota. Should we always emit an error? For now I've added it as a warning.

You have chosen to install all tools. An estimated 2840 MB of additional disk space will be used.
***WARNING: Your zopen file-system (/home/itodoro/zopen) only has 260 MB of available space.
Enter 'all' to confirm full installation [takes a long time so be sure!]:

@DevonianTeuchter
Copy link
Copy Markdown
Collaborator

DevonianTeuchter commented Nov 10, 2023

I like the idea as well! However, I think some filesystems are set up such that they can grow once they reach the max quota. Should we always emit an error? For now I've added it as a warning.

You have chosen to install all tools. An estimated 2840 MB of additional disk space will be used.
***WARNING: Your zopen file-system (/home/itodoro/zopen) only has 260 MB of available space.
Enter 'all' to confirm full installation [takes a long time so be sure!]:

LGTM - A warning seems reasonable - we've advised them, they can answer no and if they still proceed then that's on them - and like you say, some filesystems can dynamically resize [not sure if any z/OS compatible ones but containers and such like potentially]

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member Author

/run tests

1 similar comment
@IgorTodorovskiIBM
Copy link
Copy Markdown
Member Author

/run tests

@IgorTodorovskiIBM IgorTodorovskiIBM merged commit 7e37a89 into main Nov 15, 2023
@IgorTodorovskiIBM IgorTodorovskiIBM deleted the size_for_all branch November 15, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants