Provide the total size up front when installing all tools (zopen install --all)#564
Provide the total size up front when installing all tools (zopen install --all)#564IgorTodorovskiIBM merged 3 commits intomainfrom
Conversation
DevonianTeuchter
left a comment
There was a problem hiding this comment.
LGTM as-is but would a 'du' space check be a useful addition at this point to save failure during the install if insufficient space?
MikeFultonDev
left a comment
There was a problem hiding this comment.
LGTM - if you haven't already, do you want to open an issue to handle the size calculation for a set of packages (as opposed to all)?
|
i like that. i also think if there is less than XX MB in the file system, we should just fail too... If it's close enough to empty, they should clean up. |
|
I like the idea as well! However, I think some filesystems are set up such that they can grow once they reach the max quota. Should we always emit an error? For now I've added it as a warning. |
LGTM - A warning seems reasonable - we've advised them, they can answer no and if they still proceed then that's on them - and like you say, some filesystems can dynamically resize [not sure if any z/OS compatible ones but containers and such like potentially] |
|
/run tests |
1 similar comment
|
/run tests |
Output as of today: