Skip to content

Add a blurb about github actions and rename Pipeline to Testing#568

Merged
IgorTodorovskiIBM merged 2 commits intomainfrom
add_github_action_docs
Mar 7, 2024
Merged

Add a blurb about github actions and rename Pipeline to Testing#568
IgorTodorovskiIBM merged 2 commits intomainfrom
add_github_action_docs

Conversation

@IgorTodorovskiIBM
Copy link
Copy Markdown
Member

No description provided.

Comment thread docs/Guides/Testing.md

z/OS Open Tools ports take advantage of Github Actions to be able to build and test project changes directly on our CI/CD z/OS machines. The [build and test](https://github.com/ZOSOpenTools/meta/blob/main/.github/workflows/build_and_test.yml) job triggers a build on Jenkins and reports the status and test results back. If the Github Action is triggered on a Pull Request, then a status check is created to represent the status of the build and test job. Is is strong recommended that you wait for a green status before merging in your approved Pull Request.

Additionally, each port has its own github workflow in place, which calls the build and test job. For example, metaport has the following [workflow](https://github.com/ZOSOpenTools/metaport/blob/main/.github/workflows/build_and_test.yml), which triggers the build and test job to be executed on specific events, including on opened or updated pull requests and on the comment '/run tests'. It also speficies which files to ignore.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be required not strongly recommended. We can say that if there is agreement from the reviewers that a failed pretest can be overruled then I would be ok with that

Copy link
Copy Markdown
Collaborator

@MikeFultonDev MikeFultonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IgorTodorovskiIBM IgorTodorovskiIBM merged commit 31fc570 into main Mar 7, 2024
@IgorTodorovskiIBM IgorTodorovskiIBM deleted the add_github_action_docs branch March 7, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants