Query bug#590
Merged
DevonianTeuchter merged 2 commits intomainfrom Nov 22, 2023
Merged
Conversation
DevonianTeuchter
requested review from
HarithaIBM,
IgorTodorovskiIBM and
MikeFultonDev
as code owners
| colored="${GREEN}" | ||
| elif [ ${percentage} -gt 50 ]; then | ||
| colored="${BLUE}" | ||
| colored="${BOLD}${BLUE}" |
Member
There was a problem hiding this comment.
Is the blue more recognizable when bold?
Collaborator
Author
There was a problem hiding this comment.
To my eyes, yes - it's brighter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug with querying for installed packages from within zopen install/upgrade. zopen-install calls zopen-query directly rather than using the list verb for zopen; the parameters are different for when a "list" action is required - zopen uses the "list" verb, zopen-query uses the "--list" parameter. zopen-install incorrectly specifies "list" rather than "--list" and as such, the list of returned packages can become corrupted. For small setups, this might not be noticeable as the returned list is sanitised, however with a sufficiently long list (like if a "--all" had been used previously), the list of packages will become corrupt and break the upgrade mechanism as well as taking a longer period of time than it should. Full installations might not be upgradeable using the "zopen upgrade" command, packages might need to be manually listed.
The find used to determine the installed packages also recurses too deeply, returning huge volumes of data - again, this gets sanitised for processing but takes a long period of time and can cause issues with envvar lengths etc. The zosfind should only now pick up in the current directory after switching to PKGINSTALL
In addition, colorization of columns in detailed mode and column headers have been updated and various shellcheck issues resolved.